src: improve error handling in CloneSSLCerts #44410

tniessen · 2022-08-26T16:17:14Z

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error.

nodejs-github-bot · 2022-08-26T16:17:18Z

Review requested:

@nodejs/crypto

src/crypto/crypto_common.cc

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error.

nodejs-github-bot · 2022-08-31T08:19:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46340/

tniessen · 2022-08-31T12:07:33Z

This needs another approval because the last commit addresses the review comment.

nodejs-github-bot · 2022-09-01T12:59:45Z

Landed in 82cfb50

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error. PR-URL: #44410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error. PR-URL: nodejs#44410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error. PR-URL: #44410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [node](https://github.com/nodejs/node) | stage | minor | `16.17.1-bullseye` -> `16.18.0-bullseye` | --- ### Release Notes <details> <summary>nodejs/node</summary> ### [`v16.18.0`](https://github.com/nodejs/node/releases/tag/v16.18.0) [Compare Source](https://github.com/nodejs/node/compare/v16.17.1...v16.18.0) ##### Notable changes - \[[`1cc050eaa8`](https://github.com/nodejs/node/commit/1cc050eaa8)] - **(SEMVER-MINOR)** **assert**: add `getCalls` and `reset` to callTracker (Moshe Atlow) [#44191](https://github.com/nodejs/node/pull/44191) - \[[`e5c9975f11`](https://github.com/nodejs/node/commit/e5c9975f11)] - **(SEMVER-MINOR)** **crypto**: allow zero-length secret KeyObject (Filip Skokan) [#44201](https://github.com/nodejs/node/pull/44201) - \[[`317cd051ce`](https://github.com/nodejs/node/commit/317cd051ce)] - **(SEMVER-MINOR)** **crypto**: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) [#44201](https://github.com/nodejs/node/pull/44201) - \[[`f80bdc5ef3`](https://github.com/nodejs/node/commit/f80bdc5ef3)] - **(SEMVER-MINOR)** **doc**: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) [#44588](https://github.com/nodejs/node/pull/44588) - \[[`8398e98b1b`](https://github.com/nodejs/node/commit/8398e98b1b)] - **(SEMVER-MINOR)** **http**: make idle http parser count configurable (theanarkh) [#43974](https://github.com/nodejs/node/pull/43974) - \[[`2cd2f56962`](https://github.com/nodejs/node/commit/2cd2f56962)] - **(SEMVER-MINOR)** **http**: throw error on content-length mismatch (sidwebworks) [#44378](https://github.com/nodejs/node/pull/44378) - \[[`6be761e8a9`](https://github.com/nodejs/node/commit/6be761e8a9)] - **(SEMVER-MINOR)** **lib**: add diagnostics channel for process and worker (theanarkh) [#44045](https://github.com/nodejs/node/pull/44045) - \[[`1400796cef`](https://github.com/nodejs/node/commit/1400796cef)] - **(SEMVER-MINOR)** **net,tls**: pass a valid socket on `tlsClientError` (Daeyeon Jeong) [#44021](https://github.com/nodejs/node/pull/44021) - \[[`092239a7f1`](https://github.com/nodejs/node/commit/092239a7f1)] - **(SEMVER-MINOR)** **net**: add local family (theanarkh) [#43975](https://github.com/nodejs/node/pull/43975) - \[[`381e11e18e`](https://github.com/nodejs/node/commit/381e11e18e)] - **(SEMVER-MINOR)** **report**: expose report public native apis (Chengzhong Wu) [#44255](https://github.com/nodejs/node/pull/44255) - \[[`2ba547aa5b`](https://github.com/nodejs/node/commit/2ba547aa5b)] - **(SEMVER-MINOR)** **src**: expose environment RequestInterrupt api (Chengzhong Wu) [#44362](https://github.com/nodejs/node/pull/44362) - \[[`6ed3367155`](https://github.com/nodejs/node/commit/6ed3367155)] - **(SEMVER-MINOR)** **stream**: add `ReadableByteStream.tee()` (Daeyeon Jeong) [#44505](https://github.com/nodejs/node/pull/44505) - \[[`0fbedac6ce`](https://github.com/nodejs/node/commit/0fbedac6ce)] - **(SEMVER-MINOR)** **test_runner**: add before/after/each hooks (Moshe Atlow) [#43730](https://github.com/nodejs/node/pull/43730) - \[[`70563b53c5`](https://github.com/nodejs/node/commit/70563b53c5)] - **(SEMVER-MINOR)** **util**: add `maxArrayLength` option to Set and Map (Kohei Ueno) [#43576](https://github.com/nodejs/node/pull/43576) ##### Commits - \[[`1cc050eaa8`](https://github.com/nodejs/node/commit/1cc050eaa8)] - **(SEMVER-MINOR)** **assert**: add `getCalls` and `reset` to callTracker (Moshe Atlow) [#44191](https://github.com/nodejs/node/pull/44191) - \[[`2e87cdd1e6`](https://github.com/nodejs/node/commit/2e87cdd1e6)] - **benchmark**: fix startup benchmark (Evan Lucas) [#44727](https://github.com/nodejs/node/pull/44727) - \[[`29c0f9ef30`](https://github.com/nodejs/node/commit/29c0f9ef30)] - **benchmark**: add stream destroy benchmark (SindreXie) [#44533](https://github.com/nodejs/node/pull/44533) - \[[`f01bb58c1e`](https://github.com/nodejs/node/commit/f01bb58c1e)] - **bootstrap**: update comments in bootstrap/node.js (Joyee Cheung) [#44726](https://github.com/nodejs/node/pull/44726) - \[[`db151e182f`](https://github.com/nodejs/node/commit/db151e182f)] - **bootstrap**: stop delaying instantiation of maps in per-context scripts (Darshan Sen) [#42934](https://github.com/nodejs/node/pull/42934) - \[[`f700074c57`](https://github.com/nodejs/node/commit/f700074c57)] - **buffer**: fix `atob` input validation (Austin Kelleher) [#42662](https://github.com/nodejs/node/pull/42662) - \[[`e10095a759`](https://github.com/nodejs/node/commit/e10095a759)] - **build**: update timezone-update.yml (Alex) [#44717](https://github.com/nodejs/node/pull/44717) - \[[`bec2ede687`](https://github.com/nodejs/node/commit/bec2ede687)] - **build**: remove redundant entry in crypto (Jiawen Geng) [#44604](https://github.com/nodejs/node/pull/44604) - \[[`7b3a2c3353`](https://github.com/nodejs/node/commit/7b3a2c3353)] - **build**: rewritten the Android build system (BuShe Pie) [#44207](https://github.com/nodejs/node/pull/44207) - \[[`e96bb14942`](https://github.com/nodejs/node/commit/e96bb14942)] - **build**: add --libdir flag to configure (Stephen Gallagher) [#44361](https://github.com/nodejs/node/pull/44361) - \[[`2a4491b34d`](https://github.com/nodejs/node/commit/2a4491b34d)] - **build**: added NINJA env to customize ninja binary (Jeff Dickey) [#44293](https://github.com/nodejs/node/pull/44293) - \[[`aaad7a64b4`](https://github.com/nodejs/node/commit/aaad7a64b4)] - **build**: enable pointer authentication for branch protection on arm64 (Jeremiah Gowdy) [#43200](https://github.com/nodejs/node/pull/43200) - \[[`041bb54143`](https://github.com/nodejs/node/commit/041bb54143)] - **build**: add workflow to label flaky-test platform (Rafael Gonzaga) [#44042](https://github.com/nodejs/node/pull/44042) - \[[`58d85c1109`](https://github.com/nodejs/node/commit/58d85c1109)] - **build**: optimized and fixed building configuration to Android (BuShe) [#44016](https://github.com/nodejs/node/pull/44016) - \[[`5cd8b7bc8b`](https://github.com/nodejs/node/commit/5cd8b7bc8b)] - **build**: allow test-internet on forks if not scheduled (Rich Trott) [#44073](https://github.com/nodejs/node/pull/44073) - \[[`9698be9347`](https://github.com/nodejs/node/commit/9698be9347)] - **build**: skip test-internet run on forks (Rich Trott) [#44054](https://github.com/nodejs/node/pull/44054) - \[[`25e6f48e4a`](https://github.com/nodejs/node/commit/25e6f48e4a)] - **child_process**: remove lookup of undefined property (Colin Ihrig) [#44766](https://github.com/nodejs/node/pull/44766) - \[[`a3bdd07321`](https://github.com/nodejs/node/commit/a3bdd07321)] - **cluster**: fix cluster rr distribute error (theanarkh) [#44202](https://github.com/nodejs/node/pull/44202) - \[[`317cd051ce`](https://github.com/nodejs/node/commit/317cd051ce)] - **(SEMVER-MINOR)** **crypto**: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) [#44201](https://github.com/nodejs/node/pull/44201) - \[[`e5c9975f11`](https://github.com/nodejs/node/commit/e5c9975f11)] - **(SEMVER-MINOR)** **crypto**: allow zero-length secret KeyObject (Filip Skokan) [#44201](https://github.com/nodejs/node/pull/44201) - \[[`7e705d8d74`](https://github.com/nodejs/node/commit/7e705d8d74)] - **crypto**: fix webcrypto deriveBits validations (Filip Skokan) [#44173](https://github.com/nodejs/node/pull/44173) - \[[`7ad2a268b9`](https://github.com/nodejs/node/commit/7ad2a268b9)] - **crypto**: fix webcrypto EC key namedCurve validation errors (Filip Skokan) [#44172](https://github.com/nodejs/node/pull/44172) - \[[`2c938d73ff`](https://github.com/nodejs/node/commit/2c938d73ff)] - **crypto**: fix webcrypto operation errors to be OperationError (Filip Skokan) [#44171](https://github.com/nodejs/node/pull/44171) - \[[`a6e2cb40a6`](https://github.com/nodejs/node/commit/a6e2cb40a6)] - **crypto**: fix webcrypto generateKey() AES key length validation error (Filip Skokan) [#44170](https://github.com/nodejs/node/pull/44170) - \[[`7e07cce24b`](https://github.com/nodejs/node/commit/7e07cce24b)] - **crypto**: use EVP_PKEY_CTX_set_dsa_paramgen_q_bits when available (David Benjamin) [#44561](https://github.com/nodejs/node/pull/44561) - \[[`1fc6394741`](https://github.com/nodejs/node/commit/1fc6394741)] - **crypto**: restrict PBKDF2 args to signed int (Tobias Nießen) [#44575](https://github.com/nodejs/node/pull/44575) - \[[`9a52ee7577`](https://github.com/nodejs/node/commit/9a52ee7577)] - **crypto**: handle invalid prepareAsymmetricKey JWK inputs (Filip Skokan) [#44475](https://github.com/nodejs/node/pull/44475) - \[[`7100baee40`](https://github.com/nodejs/node/commit/7100baee40)] - **crypto**: use actual option name in error message (Tobias Nießen) [#44455](https://github.com/nodejs/node/pull/44455) - \[[`579e066c3a`](https://github.com/nodejs/node/commit/579e066c3a)] - **crypto**: add digest name to INVALID_DIGEST errors (Tobias Nießen) [#44468](https://github.com/nodejs/node/pull/44468) - \[[`566d80f622`](https://github.com/nodejs/node/commit/566d80f622)] - **crypto**: improve RSA-PSS digest error messages (Tobias Nießen) [#44307](https://github.com/nodejs/node/pull/44307) - \[[`f717c1e06a`](https://github.com/nodejs/node/commit/f717c1e06a)] - **debugger**: decrease timeout used to wait for the port to be free (Joyee Cheung) [#44359](https://github.com/nodejs/node/pull/44359) - \[[`0f2fcaf771`](https://github.com/nodejs/node/commit/0f2fcaf771)] - **deps**: update to ngtcp2 0.8.1 and nghttp3 0.7.0 (Tobias Nießen) [#44622](https://github.com/nodejs/node/pull/44622) - \[[`1a8aada69d`](https://github.com/nodejs/node/commit/1a8aada69d)] - **deps**: update corepack to 0.14.1 (Node.js GitHub Bot) [#44704](https://github.com/nodejs/node/pull/44704) - \[[`e4f18b4f34`](https://github.com/nodejs/node/commit/e4f18b4f34)] - **deps**: update ngtcp2 update instructions (Tobias Nießen) [#44619](https://github.com/nodejs/node/pull/44619) - \[[`21b5ab1494`](https://github.com/nodejs/node/commit/21b5ab1494)] - **deps**: upgrade npm to 8.19.2 (npm team) [#44632](https://github.com/nodejs/node/pull/44632) - \[[`916b319e7a`](https://github.com/nodejs/node/commit/916b319e7a)] - **deps**: update to uvwasi 0.0.13 (Colin Ihrig) [#44524](https://github.com/nodejs/node/pull/44524) - \[[`67cbbcc902`](https://github.com/nodejs/node/commit/67cbbcc902)] - **deps**: update corepack to 0.14.0 (Node.js GitHub Bot) [#44509](https://github.com/nodejs/node/pull/44509) - \[[`9f14dc1a8f`](https://github.com/nodejs/node/commit/9f14dc1a8f)] - **deps**: update Acorn to v8.8.0 (Michaël Zasso) [#44437](https://github.com/nodejs/node/pull/44437) - \[[`1811a6aaa8`](https://github.com/nodejs/node/commit/1811a6aaa8)] - **deps**: update icu tzdata to 2022b (Matías Zúñiga) [#44283](https://github.com/nodejs/node/pull/44283) - \[[`0c4953cbd1`](https://github.com/nodejs/node/commit/0c4953cbd1)] - **deps**: update undici to 5.9.1 (Node.js GitHub Bot) [#44319](https://github.com/nodejs/node/pull/44319) - \[[`8a921fea74`](https://github.com/nodejs/node/commit/8a921fea74)] - **deps**: upgrade npm to 8.19.1 (npm team) [#44486](https://github.com/nodejs/node/pull/44486) - \[[`763a63c14b`](https://github.com/nodejs/node/commit/763a63c14b)] - **deps**: update corepack to 0.13.0 (Node.js GitHub Bot) [#44318](https://github.com/nodejs/node/pull/44318) - \[[`fdb699c84a`](https://github.com/nodejs/node/commit/fdb699c84a)] - **deps**: upgrade npm to 8.18.0 (npm team) [#44263](https://github.com/nodejs/node/pull/44263) - \[[`2a44872f96`](https://github.com/nodejs/node/commit/2a44872f96)] - **deps**: update corepack to 0.12.3 (Node.js GitHub Bot) [#44229](https://github.com/nodejs/node/pull/44229) - \[[`48967e4b34`](https://github.com/nodejs/node/commit/48967e4b34)] - **deps**: upgrade npm to 8.17.0 (npm team) [#44205](https://github.com/nodejs/node/pull/44205) - \[[`0484122f71`](https://github.com/nodejs/node/commit/0484122f71)] - **deps**: update undici to 5.8.2 (Node.js GitHub Bot) [#44187](https://github.com/nodejs/node/pull/44187) - \[[`e404ac7eed`](https://github.com/nodejs/node/commit/e404ac7eed)] - **deps**: update undici to 5.8.1 (Node.js GitHub Bot) [#44158](https://github.com/nodejs/node/pull/44158) - \[[`9a5ee5e9e3`](https://github.com/nodejs/node/commit/9a5ee5e9e3)] - **deps**: update corepack to 0.12.2 (Node.js GitHub Bot) [#44159](https://github.com/nodejs/node/pull/44159) - \[[`3657cb277b`](https://github.com/nodejs/node/commit/3657cb277b)] - **deps**: remove unnecessary file (Brian White) [#44133](https://github.com/nodejs/node/pull/44133) - \[[`d66a807596`](https://github.com/nodejs/node/commit/d66a807596)] - **deps**: upgrade npm to 8.16.0 (npm team) [#44119](https://github.com/nodejs/node/pull/44119) - \[[`ec998be61c`](https://github.com/nodejs/node/commit/ec998be61c)] - **deps**: upgrade npm to 8.15.1 (npm team) [#44013](https://github.com/nodejs/node/pull/44013) - \[[`e9e856ae95`](https://github.com/nodejs/node/commit/e9e856ae95)] - **deps**: upgrade base64 to [`dc6a41c`](https://github.com/nodejs/node/commit/dc6a41ce36e) (Brian White) [#44032](https://github.com/nodejs/node/pull/44032) - \[[`8ea9a71b15`](https://github.com/nodejs/node/commit/8ea9a71b15)] - **deps,src**: use SIMD for normal base64 encoding (Brian White) [#39775](https://github.com/nodejs/node/pull/39775) - \[[`969a12be4b`](https://github.com/nodejs/node/commit/969a12be4b)] - **doc**: remove "currently" and comma splice from child_process.md (Rich Trott) [#44789](https://github.com/nodejs/node/pull/44789) - \[[`5e4a2e94a1`](https://github.com/nodejs/node/commit/5e4a2e94a1)] - **doc**: mention git node backport (RafaelGSS) [#44764](https://github.com/nodejs/node/pull/44764) - \[[`618c9c8260`](https://github.com/nodejs/node/commit/618c9c8260)] - **doc**: ensure to revert node_version changes (Rafael Gonzaga) [#44760](https://github.com/nodejs/node/pull/44760) - \[[`e0fe11c189`](https://github.com/nodejs/node/commit/e0fe11c189)] - **doc**: fix description for `napi_get_cb_info()` in `n-api.md` (Daeyeon Jeong) [#44761](https://github.com/nodejs/node/pull/44761) - \[[`895719da65`](https://github.com/nodejs/node/commit/895719da65)] - **doc**: fix v16.17.1 security release changelog (Ruy Adorno) [#44759](https://github.com/nodejs/node/pull/44759) - \[[`fe832a0647`](https://github.com/nodejs/node/commit/fe832a0647)] - **doc**: update the deprecation for exit code to clarify its scope (Daeyeon Jeong) [#44714](https://github.com/nodejs/node/pull/44714) - \[[`3872abd9a6`](https://github.com/nodejs/node/commit/3872abd9a6)] - **doc**: update guidance for adding new modules (Michael Dawson) [#44576](https://github.com/nodejs/node/pull/44576) - \[[`f381a1e86a`](https://github.com/nodejs/node/commit/f381a1e86a)] - **doc**: add registry number for Electron 22 (Keeley Hammond) [#44748](https://github.com/nodejs/node/pull/44748) - \[[`8d3cb6c08a`](https://github.com/nodejs/node/commit/8d3cb6c08a)] - **doc**: include code examples for webstreams consumers (Lucas Santos) [#44387](https://github.com/nodejs/node/pull/44387) - \[[`9e83c00e0b`](https://github.com/nodejs/node/commit/9e83c00e0b)] - **doc**: mention where to push security commits (RafaelGSS) [#44691](https://github.com/nodejs/node/pull/44691) - \[[`bc9f8d24ce`](https://github.com/nodejs/node/commit/bc9f8d24ce)] - **doc**: remove extra space on threadpool usage (Connor Burton) [#44734](https://github.com/nodejs/node/pull/44734) - \[[`3e38ba53cc`](https://github.com/nodejs/node/commit/3e38ba53cc)] - **doc**: make legacy banner slightly less bright (Rich Trott) [#44665](https://github.com/nodejs/node/pull/44665) - \[[`0f88588f52`](https://github.com/nodejs/node/commit/0f88588f52)] - **doc**: improve building doc for Windows Powershell (Brian Muenzenmeyer) [#44625](https://github.com/nodejs/node/pull/44625) - \[[`5ee0127540`](https://github.com/nodejs/node/commit/5ee0127540)] - **doc**: maintain only one list of MODP groups (Tobias Nießen) [#44644](https://github.com/nodejs/node/pull/44644) - \[[`6881ecb0e2`](https://github.com/nodejs/node/commit/6881ecb0e2)] - **doc**: add legendecas to TSC list (Michael Dawson) [#44662](https://github.com/nodejs/node/pull/44662) - \[[`3614f5ace3`](https://github.com/nodejs/node/commit/3614f5ace3)] - **doc**: remove comma in README.md (Taha-Chaudhry) [#44599](https://github.com/nodejs/node/pull/44599) - \[[`c9af43616c`](https://github.com/nodejs/node/commit/c9af43616c)] - **doc**: use serial comma in report docs (Daeyeon Jeong) [#44608](https://github.com/nodejs/node/pull/44608) - \[[`ff9ef61646`](https://github.com/nodejs/node/commit/ff9ef61646)] - **doc**: use serial comma in stream docs (Daeyeon Jeong) [#44609](https://github.com/nodejs/node/pull/44609) - \[[`90eaae3ef1`](https://github.com/nodejs/node/commit/90eaae3ef1)] - **doc**: remove empty line in YAML block (Claudio Wunder) [#44617](https://github.com/nodejs/node/pull/44617) - \[[`f80bdc5ef3`](https://github.com/nodejs/node/commit/f80bdc5ef3)] - **(SEMVER-MINOR)** **doc**: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) [#44588](https://github.com/nodejs/node/pull/44588) - \[[`9fac6dd1c1`](https://github.com/nodejs/node/commit/9fac6dd1c1)] - **doc**: remove old OpenSSL ENGINE constants (Tobias Nießen) [#44589](https://github.com/nodejs/node/pull/44589) - \[[`53543c6d81`](https://github.com/nodejs/node/commit/53543c6d81)] - **doc**: fix heading levels for test runner hooks (Fabian Meyer) [#44603](https://github.com/nodejs/node/pull/44603) - \[[`2084ad61a7`](https://github.com/nodejs/node/commit/2084ad61a7)] - **doc**: fix errors in http.md (Luigi Pinca) [#44587](https://github.com/nodejs/node/pull/44587) - \[[`cc55e84ddc`](https://github.com/nodejs/node/commit/cc55e84ddc)] - **doc**: fix vm.Script createCachedData example (Chengzhong Wu) [#44487](https://github.com/nodejs/node/pull/44487) - \[[`8187f03834`](https://github.com/nodejs/node/commit/8187f03834)] - **doc**: mention how to get commit release (Rafael Gonzaga) [#44572](https://github.com/nodejs/node/pull/44572) - \[[`d068978933`](https://github.com/nodejs/node/commit/d068978933)] - **doc**: fix link in `process.md` (Antoine du Hamel) [#44594](https://github.com/nodejs/node/pull/44594) - \[[`0747facb63`](https://github.com/nodejs/node/commit/0747facb63)] - **doc**: do not use weak MODP group in example (Tobias Nießen) [#44585](https://github.com/nodejs/node/pull/44585) - \[[`e26d95ef9a`](https://github.com/nodejs/node/commit/e26d95ef9a)] - **doc**: remove ebpf from supported tooling list (Rafael Gonzaga) [#44549](https://github.com/nodejs/node/pull/44549) - \[[`9d24c7a8c7`](https://github.com/nodejs/node/commit/9d24c7a8c7)] - **doc**: emphasize that createCipher is never secure (Tobias Nießen) [#44538](https://github.com/nodejs/node/pull/44538) - \[[`6d881b8611`](https://github.com/nodejs/node/commit/6d881b8611)] - **doc**: document attribute Script.cachedDataRejected (Chengzhong Wu) [#44451](https://github.com/nodejs/node/pull/44451) - \[[`d846e5bac5`](https://github.com/nodejs/node/commit/d846e5bac5)] - **doc**: move policy docs to the permissions scope (Rafael Gonzaga) [#44222](https://github.com/nodejs/node/pull/44222) - \[[`5c721a33c3`](https://github.com/nodejs/node/commit/5c721a33c3)] - **doc**: add performance note to `--enable-source-maps` docs (Saurabh Daware) [#43817](https://github.com/nodejs/node/pull/43817) - \[[`1998bc80b5`](https://github.com/nodejs/node/commit/1998bc80b5)] - **doc**: fix release guide example consistency (Ruy Adorno) [#44385](https://github.com/nodejs/node/pull/44385) - \[[`7b691729b1`](https://github.com/nodejs/node/commit/7b691729b1)] - **doc**: note on release guide to update `main` branch (Ruy Adorno) [#44384](https://github.com/nodejs/node/pull/44384) - \[[`7ec097fa99`](https://github.com/nodejs/node/commit/7ec097fa99)] - **doc**: mention cherry-pick edge-case on release (RafaelGSS) [#44408](https://github.com/nodejs/node/pull/44408) - \[[`4a4025181c`](https://github.com/nodejs/node/commit/4a4025181c)] - **doc**: fix spacing issue in `--build-snapshot` help text (Shohei YOSHIDA) [#44435](https://github.com/nodejs/node/pull/44435) - \[[`a5906a09dc`](https://github.com/nodejs/node/commit/a5906a09dc)] - **doc**: apply scroll-margin-top to h2, h3 elements (metonym) [#44414](https://github.com/nodejs/node/pull/44414) - \[[`0e99139df4`](https://github.com/nodejs/node/commit/0e99139df4)] - **doc**: use serial comma in addons docs (Tobias Nießen) [#44482](https://github.com/nodejs/node/pull/44482) - \[[`8ea3e6f839`](https://github.com/nodejs/node/commit/8ea3e6f839)] - **doc**: do not use "Returns:" for crypto.constants (Tobias Nießen) [#44481](https://github.com/nodejs/node/pull/44481) - \[[`a1dbe4bc79`](https://github.com/nodejs/node/commit/a1dbe4bc79)] - **doc**: add history for net.createServer() options (Luigi Pinca) [#44326](https://github.com/nodejs/node/pull/44326) - \[[`eb90d650d4`](https://github.com/nodejs/node/commit/eb90d650d4)] - **doc**: fix typo in test runner code examples (Moshe Atlow) [#44351](https://github.com/nodejs/node/pull/44351) - \[[`17c5b978a5`](https://github.com/nodejs/node/commit/17c5b978a5)] - **doc**: add daeyeon to collaborators (Daeyeon Jeong) [#44355](https://github.com/nodejs/node/pull/44355) - \[[`c1458063ee`](https://github.com/nodejs/node/commit/c1458063ee)] - **doc**: fix style of n-api.md (theanarkh) [#44377](https://github.com/nodejs/node/pull/44377) - \[[`cf60c6bc74`](https://github.com/nodejs/node/commit/cf60c6bc74)] - **doc**: add missing imports in events sample code (Brian Evans) [#44337](https://github.com/nodejs/node/pull/44337) - \[[`89e5ac9676`](https://github.com/nodejs/node/commit/89e5ac9676)] - **doc**: add missing parenthesis in TLSSocket section (Tobias Nießen) [#44512](https://github.com/nodejs/node/pull/44512) - \[[`5ac344b2a2`](https://github.com/nodejs/node/commit/5ac344b2a2)] - **doc**: fix optionality of callback arg of checkPrime (Tobias Nießen) [#44311](https://github.com/nodejs/node/pull/44311) - \[[`87cc487e28`](https://github.com/nodejs/node/commit/87cc487e28)] - **doc**: fix typo (Hana) [#44262](https://github.com/nodejs/node/pull/44262) - \[[`5978eb1ae8`](https://github.com/nodejs/node/commit/5978eb1ae8)] - **doc**: add TypeScript execution requirements (Michael Dawson) [#44030](https://github.com/nodejs/node/pull/44030) - \[[`42948364e2`](https://github.com/nodejs/node/commit/42948364e2)] - **doc**: add cola119 to collaborators (cola119) [#44248](https://github.com/nodejs/node/pull/44248) - \[[`6196bcedd0`](https://github.com/nodejs/node/commit/6196bcedd0)] - **doc**: improved building doc for Android (BuShe) [#44166](https://github.com/nodejs/node/pull/44166) - \[[`afe6c87bb5`](https://github.com/nodejs/node/commit/afe6c87bb5)] - **doc**: add MoLow to collaborators (Moshe Atlow) [#44214](https://github.com/nodejs/node/pull/44214) - \[[`82ff3dabc5`](https://github.com/nodejs/node/commit/82ff3dabc5)] - **doc**: update tags in adding-new-napi-api.md (Chengzhong Wu) [#44190](https://github.com/nodejs/node/pull/44190) - \[[`16d6d45ee8`](https://github.com/nodejs/node/commit/16d6d45ee8)] - **doc**: fix typo in diagnostics_channel (Evan Lucas) [#44199](https://github.com/nodejs/node/pull/44199) - \[[`ed1d0c9203`](https://github.com/nodejs/node/commit/ed1d0c9203)] - **doc**: add Retry CI in collaborator guide (Livia Medeiros) [#44130](https://github.com/nodejs/node/pull/44130) - \[[`1022ece43f`](https://github.com/nodejs/node/commit/1022ece43f)] - **doc**: remove unused code in call tracker example (Colin Ihrig) [#44127](https://github.com/nodejs/node/pull/44127) - \[[`0c95d45410`](https://github.com/nodejs/node/commit/0c95d45410)] - **doc**: add theanarkh to collaborators (theanarkh) [#44131](https://github.com/nodejs/node/pull/44131) - \[[`97ad1a0f03`](https://github.com/nodejs/node/commit/97ad1a0f03)] - **doc**: clarify tls.tlsSocket.getCipher().version (Adam Majer) [#44086](https://github.com/nodejs/node/pull/44086) - \[[`9e10ee70a3`](https://github.com/nodejs/node/commit/9e10ee70a3)] - **doc**: update repository list in onboarding doc (Rich Trott) [#44089](https://github.com/nodejs/node/pull/44089) - \[[`3171d55ef8`](https://github.com/nodejs/node/commit/3171d55ef8)] - **doc**: add ErickWendel to collaborators (Erick Wendel) [#44088](https://github.com/nodejs/node/pull/44088) - \[[`c9c2114a75`](https://github.com/nodejs/node/commit/c9c2114a75)] - **doc**: update collaborator email (Ruy Adorno) [#44044](https://github.com/nodejs/node/pull/44044) - \[[`1f9246a24f`](https://github.com/nodejs/node/commit/1f9246a24f)] - **doc**: copyedit `test.md` (Antoine du Hamel) [#44061](https://github.com/nodejs/node/pull/44061) - \[[`76e9cf2a46`](https://github.com/nodejs/node/commit/76e9cf2a46)] - **doc**: add kvakil to triagers (Keyhan Vakil) [#43996](https://github.com/nodejs/node/pull/43996) - \[[`5a34c575ad`](https://github.com/nodejs/node/commit/5a34c575ad)] - **doc**: clarify part of onboarding guide regarding adding to teams (Darshan Sen) [#44024](https://github.com/nodejs/node/pull/44024) - \[[`5d3b8ab2d6`](https://github.com/nodejs/node/commit/5d3b8ab2d6)] - **doc**: fix code examples in `crypto.md` (Antoine du Hamel) [#44053](https://github.com/nodejs/node/pull/44053) - \[[`e59c095b23`](https://github.com/nodejs/node/commit/e59c095b23)] - **doc**: claim ABI version for Electron 21 (Keeley Hammond) [#44034](https://github.com/nodejs/node/pull/44034) - \[[`88b0d406ac`](https://github.com/nodejs/node/commit/88b0d406ac)] - **doc**: remove old reference from crypto/README.md (Tobias Nießen) [#44012](https://github.com/nodejs/node/pull/44012) - \[[`58c97216ee`](https://github.com/nodejs/node/commit/58c97216ee)] - **doc**: add missing env vars to man page (cola119) [#43492](https://github.com/nodejs/node/pull/43492) - \[[`c07159215d`](https://github.com/nodejs/node/commit/c07159215d)] - **doc**: list supported MODP groups explicitly (Tobias Nießen) [#43986](https://github.com/nodejs/node/pull/43986) - \[[`be2feec1f0`](https://github.com/nodejs/node/commit/be2feec1f0)] - **doc**: fix typo in packages.md (Dominic Saadi) [#44005](https://github.com/nodejs/node/pull/44005) - \[[`9f7a728168`](https://github.com/nodejs/node/commit/9f7a728168)] - **doc**: fix typos in `test.md` (Antoine du Hamel) [#43997](https://github.com/nodejs/node/pull/43997) - \[[`21a29d4584`](https://github.com/nodejs/node/commit/21a29d4584)] - **doc**: add missing test runner option (Moshe Atlow) [#43989](https://github.com/nodejs/node/pull/43989) - \[[`6758c63eba`](https://github.com/nodejs/node/commit/6758c63eba)] - **doc,crypto**: cleanup removed pbkdf2 behaviours (Filip Skokan) [#44733](https://github.com/nodejs/node/pull/44733) - \[[`891c4e742f`](https://github.com/nodejs/node/commit/891c4e742f)] - **doc,inspector**: document changes of inspector.close (Chengzhong Wu) [#44628](https://github.com/nodejs/node/pull/44628) - \[[`4308d95d1d`](https://github.com/nodejs/node/commit/4308d95d1d)] - **doc,report**: document special filenames (Chengzhong Wu) [#44257](https://github.com/nodejs/node/pull/44257) - \[[`89c837a48d`](https://github.com/nodejs/node/commit/89c837a48d)] - **doc,worker**: document resourceLimits overrides (Keyhan Vakil) [#43992](https://github.com/nodejs/node/pull/43992) - \[[`8f6bd5a402`](https://github.com/nodejs/node/commit/8f6bd5a402)] - **doc,worker**: deprecate `--trace-atomics-wait` (Keyhan Vakil) [#44093](https://github.com/nodejs/node/pull/44093) - \[[`9593c37984`](https://github.com/nodejs/node/commit/9593c37984)] - **errors**: refactor to use optional chaining (SindreXie) [#44184](https://github.com/nodejs/node/pull/44184) - \[[`7cead5968e`](https://github.com/nodejs/node/commit/7cead5968e)] - **esm**: fix duplicated test (Geoffrey Booth) [#44779](https://github.com/nodejs/node/pull/44779) - \[[`5d33dfd787`](https://github.com/nodejs/node/commit/5d33dfd787)] - **esm**: do not bind loader hook functions (Antoine du Hamel) [#44122](https://github.com/nodejs/node/pull/44122) - \[[`ec7bf32350`](https://github.com/nodejs/node/commit/ec7bf32350)] - **esm**: move package config helpers (Geoffrey Booth) [#43967](https://github.com/nodejs/node/pull/43967) - \[[`42a91e36dd`](https://github.com/nodejs/node/commit/42a91e36dd)] - **esm,loader**: tidy ESMLoader internals (Jacob Smith) [#44701](https://github.com/nodejs/node/pull/44701) - \[[`d4e9384ccb`](https://github.com/nodejs/node/commit/d4e9384ccb)] - **events**: use bitset to save memory (Basit Chonka) [#43700](https://github.com/nodejs/node/pull/43700) - \[[`14ec52b949`](https://github.com/nodejs/node/commit/14ec52b949)] - **fs**: don't hard code name in validatePosition() (Colin Ihrig) [#44767](https://github.com/nodejs/node/pull/44767) - \[[`83cf979a0d`](https://github.com/nodejs/node/commit/83cf979a0d)] - **fs**: fix typo in mkdir example (SergeyTsukanov) [#44791](https://github.com/nodejs/node/pull/44791) - \[[`bbbb4460ee`](https://github.com/nodejs/node/commit/bbbb4460ee)] - **fs**: remove unused option in `fs.fstatSync()` (Livia Medeiros) [#44613](https://github.com/nodejs/node/pull/44613) - \[[`bf217f8029`](https://github.com/nodejs/node/commit/bf217f8029)] - **fs**: add encoding parameter to benchmarks (Yagiz Nizipli) [#44278](https://github.com/nodejs/node/pull/44278) - \[[`1308e68a16`](https://github.com/nodejs/node/commit/1308e68a16)] - **gyp**: libnode for ios app embedding (chexiongsheng) [#44210](https://github.com/nodejs/node/pull/44210) - \[[`2cee039070`](https://github.com/nodejs/node/commit/2cee039070)] - **http**: disable chunked encoding when OBS fold is used (Paolo Insogna) [#341](https://github.com/nodejs/node/pull/341) - \[[`2cd2f56962`](https://github.com/nodejs/node/commit/2cd2f56962)] - **(SEMVER-MINOR)** **http**: throw error on content-length mismatch (sidwebworks) [#44378](https://github.com/nodejs/node/pull/44378) - \[[`8398e98b1b`](https://github.com/nodejs/node/commit/8398e98b1b)] - **(SEMVER-MINOR)** **http**: make idle http parser count configurable (theanarkh) [#43974](https://github.com/nodejs/node/pull/43974) - \[[`fa6183fc7e`](https://github.com/nodejs/node/commit/fa6183fc7e)] - **http**: add max for http keepalive (theanarkh) [#44217](https://github.com/nodejs/node/pull/44217) - \[[`2f87ba4e03`](https://github.com/nodejs/node/commit/2f87ba4e03)] - **http**: trace http request / response (theanarkh) [#44102](https://github.com/nodejs/node/pull/44102) - \[[`5f406a3a53`](https://github.com/nodejs/node/commit/5f406a3a53)] - **http**: reuse socket only when it is drained (ywave620) [#43902](https://github.com/nodejs/node/pull/43902) - \[[`4e49d5d1b4`](https://github.com/nodejs/node/commit/4e49d5d1b4)] - **inspector**: expose inspector.close on workers (Chengzhong Wu) [#44489](https://github.com/nodejs/node/pull/44489) - \[[`c736927b0b`](https://github.com/nodejs/node/commit/c736927b0b)] - **inspector**: prevent integer overflow in open() (Tobias Nießen) [#44367](https://github.com/nodejs/node/pull/44367) - \[[`a021f1974a`](https://github.com/nodejs/node/commit/a021f1974a)] - **lib**: fix reference leak (falsandtru) [#44499](https://github.com/nodejs/node/pull/44499) - \[[`6be761e8a9`](https://github.com/nodejs/node/commit/6be761e8a9)] - **(SEMVER-MINOR)** **lib**: add diagnostics channel for process and worker (theanarkh) [#44045](https://github.com/nodejs/node/pull/44045) - \[[`ac8d2de3b0`](https://github.com/nodejs/node/commit/ac8d2de3b0)] - **lib**: reset `RegExp` statics before running user code (Antoine du Hamel) [#43741](https://github.com/nodejs/node/pull/43741) - \[[`4968ebfbe1`](https://github.com/nodejs/node/commit/4968ebfbe1)] - **lib**: refactor `validateInt32` and `validateUint32` (mawaregetsuka) [#43071](https://github.com/nodejs/node/pull/43071) - \[[`acff743113`](https://github.com/nodejs/node/commit/acff743113)] - **lib**: make `validateObject` less affected by prototype tampering (Antoine du Hamel) [#42929](https://github.com/nodejs/node/pull/42929) - \[[`59be5f89ca`](https://github.com/nodejs/node/commit/59be5f89ca)] - **lib**: use safe `Promise` alternatives when available (Antoine du Hamel) [#43476](https://github.com/nodejs/node/pull/43476) - \[[`9dad4b0d11`](https://github.com/nodejs/node/commit/9dad4b0d11)] - **lib**: add diagnostics channel and perf hooks detail (Danielle Adams) [#43984](https://github.com/nodejs/node/pull/43984) - \[[`a99e2368ea`](https://github.com/nodejs/node/commit/a99e2368ea)] - **lib**: refactor to avoid prototype pollution (Antoine du Hamel) [#43474](https://github.com/nodejs/node/pull/43474) - \[[`121c54718d`](https://github.com/nodejs/node/commit/121c54718d)] - **lib**: fix diagnostics channel (theanarkh) [#44154](https://github.com/nodejs/node/pull/44154) - \[[`594d9436c3`](https://github.com/nodejs/node/commit/594d9436c3)] - **lib**: pass env variables to child process on z/OS (alexcfyung) [#42255](https://github.com/nodejs/node/pull/42255) - \[[`9c656c89fc`](https://github.com/nodejs/node/commit/9c656c89fc)] - **lib**: add missing env vars to --help (cola119) [#43492](https://github.com/nodejs/node/pull/43492) - \[[`3aaa4109a0`](https://github.com/nodejs/node/commit/3aaa4109a0)] - **lib**: add `Promise` methods to `avoid-prototype-pollution` lint rule (Antoine du Hamel) [#43849](https://github.com/nodejs/node/pull/43849) - \[[`debf7301aa`](https://github.com/nodejs/node/commit/debf7301aa)] - **lib,test**: fix bug in InternalSocketAddress (Tobias Nießen) [#44618](https://github.com/nodejs/node/pull/44618) - \[[`c1d1ed5ae4`](https://github.com/nodejs/node/commit/c1d1ed5ae4)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44777](https://github.com/nodejs/node/pull/44777) - \[[`fe91711ed5`](https://github.com/nodejs/node/commit/fe91711ed5)] - **meta**: add mailmap entry for dnlup (Rich Trott) [#44716](https://github.com/nodejs/node/pull/44716) - \[[`b9deb1e84d`](https://github.com/nodejs/node/commit/b9deb1e84d)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44705](https://github.com/nodejs/node/pull/44705) - \[[`3564da1c94`](https://github.com/nodejs/node/commit/3564da1c94)] - **meta**: move dnlup to emeriti (dnlup) [#44667](https://github.com/nodejs/node/pull/44667) - \[[`af5d49f186`](https://github.com/nodejs/node/commit/af5d49f186)] - **meta**: update test_runner in label-pr-config (Shrujal Shah) [#44615](https://github.com/nodejs/node/pull/44615) - \[[`7ac9bafd10`](https://github.com/nodejs/node/commit/7ac9bafd10)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44591](https://github.com/nodejs/node/pull/44591) - \[[`aa68a31804`](https://github.com/nodejs/node/commit/aa68a31804)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44511](https://github.com/nodejs/node/pull/44511) - \[[`edb0851539`](https://github.com/nodejs/node/commit/edb0851539)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44422](https://github.com/nodejs/node/pull/44422) - \[[`4bdd4a3641`](https://github.com/nodejs/node/commit/4bdd4a3641)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44321](https://github.com/nodejs/node/pull/44321) - \[[`dc5478ad12`](https://github.com/nodejs/node/commit/dc5478ad12)] - **meta**: update `web streams` in label-pr-config (Daeyeon Jeong) [#44235](https://github.com/nodejs/node/pull/44235) - \[[`d535190086`](https://github.com/nodejs/node/commit/d535190086)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44231](https://github.com/nodejs/node/pull/44231) - \[[`24e3ad069d`](https://github.com/nodejs/node/commit/24e3ad069d)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44161](https://github.com/nodejs/node/pull/44161) - \[[`1924d897ad`](https://github.com/nodejs/node/commit/1924d897ad)] - **meta**: add codeowner for src/node_snapshot\* (Chengzhong Wu) [#44113](https://github.com/nodejs/node/pull/44113) - \[[`1988be9acf`](https://github.com/nodejs/node/commit/1988be9acf)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#44065](https://github.com/nodejs/node/pull/44065) - \[[`261e5acc6b`](https://github.com/nodejs/node/commit/261e5acc6b)] - **meta**: shorten PowerShell snippet for bug-report template (NicoNekoru) [#44011](https://github.com/nodejs/node/pull/44011) - \[[`1bb394e691`](https://github.com/nodejs/node/commit/1bb394e691)] - **module**: open stat/readPackage to mutations (Maël Nison) [#44537](https://github.com/nodejs/node/pull/44537) - \[[`b665171911`](https://github.com/nodejs/node/commit/b665171911)] - **module**: protect against prototype mutation (Antoine du Hamel) [#44007](https://github.com/nodejs/node/pull/44007) - \[[`092239a7f1`](https://github.com/nodejs/node/commit/092239a7f1)] - **(SEMVER-MINOR)** **net**: add local family (theanarkh) [#43975](https://github.com/nodejs/node/pull/43975) - \[[`4e0710c3a3`](https://github.com/nodejs/node/commit/4e0710c3a3)] - **net**: remove unused callback (theanarkh) [#44204](https://github.com/nodejs/node/pull/44204) - \[[`1400796cef`](https://github.com/nodejs/node/commit/1400796cef)] - **(SEMVER-MINOR)** **net,tls**: pass a valid socket on `tlsClientError` (Daeyeon Jeong) [#44021](https://github.com/nodejs/node/pull/44021) - \[[`adae66cbd4`](https://github.com/nodejs/node/commit/adae66cbd4)] - **node-api**: add deprecation code of uncaught exception (Chengzhong Wu) [#44624](https://github.com/nodejs/node/pull/44624) - \[[`f38987edcc`](https://github.com/nodejs/node/commit/f38987edcc)] - **node-api**: avoid calling virtual methods in base's dtor (Chengzhong Wu) [#44424](https://github.com/nodejs/node/pull/44424) - \[[`5b5d95d312`](https://github.com/nodejs/node/commit/5b5d95d312)] - **node-api**: cleanup redundant static modifiers (Chengzhong Wu) [#44301](https://github.com/nodejs/node/pull/44301) - \[[`8f3e8bb1fd`](https://github.com/nodejs/node/commit/8f3e8bb1fd)] - **(SEMVER-MINOR)** **os**: add machine method (theanarkh) [#44416](https://github.com/nodejs/node/pull/44416) - \[[`3cb28bdde0`](https://github.com/nodejs/node/commit/3cb28bdde0)] - **path**: change basename() argument from ext to suffix (Rich Trott) [#44774](https://github.com/nodejs/node/pull/44774) - \[[`7c5ce59dba`](https://github.com/nodejs/node/commit/7c5ce59dba)] - **perf_hooks**: fix gc elapsed time (theanarkh) [#44058](https://github.com/nodejs/node/pull/44058) - \[[`0e2c2064bb`](https://github.com/nodejs/node/commit/0e2c2064bb)] - **report**: get stack trace with cross origin contexts (Chengzhong Wu) [#44398](https://github.com/nodejs/node/pull/44398) - \[[`5355a46840`](https://github.com/nodejs/node/commit/5355a46840)] - **report**: fix missing section javascriptHeap on OOMError (Chengzhong Wu) [#44398](https://github.com/nodejs/node/pull/44398) - \[[`381e11e18e`](https://github.com/nodejs/node/commit/381e11e18e)] - **(SEMVER-MINOR)** **report**: expose report public native apis (Chengzhong Wu) [#44255](https://github.com/nodejs/node/pull/44255) - \[[`30cfe0a156`](https://github.com/nodejs/node/commit/30cfe0a156)] - **report**: print javascript stack on fatal error (Chengzhong Wu) [#44242](https://github.com/nodejs/node/pull/44242) - \[[`779761d914`](https://github.com/nodejs/node/commit/779761d914)] - **report**: add queue info for udp (theanarkh) [#44345](https://github.com/nodejs/node/pull/44345) - \[[`ff34d48d70`](https://github.com/nodejs/node/commit/ff34d48d70)] - **report**: skip report if uncaught exception is handled (Chengzhong Wu) [#44208](https://github.com/nodejs/node/pull/44208) - \[[`3e8569cfbc`](https://github.com/nodejs/node/commit/3e8569cfbc)] - **src**: remove ParseIP() in cares_wrap.cc (Tobias Nießen) [#44771](https://github.com/nodejs/node/pull/44771) - \[[`916f2c5783`](https://github.com/nodejs/node/commit/916f2c5783)] - **src**: avoid using v8 on Isolate termination (Santiago Gimeno) [#44669](https://github.com/nodejs/node/pull/44669) - \[[`4f056b57e9`](https://github.com/nodejs/node/commit/4f056b57e9)] - **src**: remove \<unistd.h> from node_os.cc (Tobias Nießen) [#44668](https://github.com/nodejs/node/pull/44668) - \[[`24172ca6fe`](https://github.com/nodejs/node/commit/24172ca6fe)] - **src**: avoid copy when creating Blob (Tobias Nießen) [#44616](https://github.com/nodejs/node/pull/44616) - \[[`eda1f4531a`](https://github.com/nodejs/node/commit/eda1f4531a)] - **src**: make ReqWrap weak (Rafael Gonzaga) [#44074](https://github.com/nodejs/node/pull/44074) - \[[`ea2957fe77`](https://github.com/nodejs/node/commit/ea2957fe77)] - **src**: make NearHeapLimitCallback() more robust (Joyee Cheung) [#44581](https://github.com/nodejs/node/pull/44581) - \[[`eaf2ffc23a`](https://github.com/nodejs/node/commit/eaf2ffc23a)] - **src**: dump isolate stats when process exits (daomingq) [#44534](https://github.com/nodejs/node/pull/44534) - \[[`49cf3459d1`](https://github.com/nodejs/node/commit/49cf3459d1)] - **src**: rename misleading arg in ClientHelloParser (Tobias Nießen) [#44500](https://github.com/nodejs/node/pull/44500) - \[[`2ba547aa5b`](https://github.com/nodejs/node/commit/2ba547aa5b)] - **(SEMVER-MINOR)** **src**: expose environment RequestInterrupt api (Chengzhong Wu) [#44362](https://github.com/nodejs/node/pull/44362) - \[[`70662f4058`](https://github.com/nodejs/node/commit/70662f4058)] - **src**: fix cppgc incompatibility in v8 (Shelley Vohr) [#43521](https://github.com/nodejs/node/pull/43521) - \[[`91ef427d2d`](https://github.com/nodejs/node/commit/91ef427d2d)] - **src**: nest namespace report in namespace node (Chengzhong Wu) [#44069](https://github.com/nodejs/node/pull/44069) - \[[`e7d30b4b49`](https://github.com/nodejs/node/commit/e7d30b4b49)] - **src**: use a typed array internally for process.\_exiting (Darshan Sen) [#43883](https://github.com/nodejs/node/pull/43883) - \[[`d76e7e4e84`](https://github.com/nodejs/node/commit/d76e7e4e84)] - **src**: improve error handling in CloneSSLCerts (Tobias Nießen) [#44410](https://github.com/nodejs/node/pull/44410) - \[[`cae9c5d5c3`](https://github.com/nodejs/node/commit/cae9c5d5c3)] - **src**: fix incorrect comments in crypto (Tobias Nießen) [#44470](https://github.com/nodejs/node/pull/44470) - \[[`c0875d1f00`](https://github.com/nodejs/node/commit/c0875d1f00)] - **src**: avoid casting std::trunc(... / ...) to size_t (Tobias Nießen) [#44467](https://github.com/nodejs/node/pull/44467) - \[[`8f3ed25e08`](https://github.com/nodejs/node/commit/8f3ed25e08)] - **src**: add error handling to `uv_uptime` call (Juan José Arboleda) [#44386](https://github.com/nodejs/node/pull/44386) - \[[`c7713f19de`](https://github.com/nodejs/node/commit/c7713f19de)] - **src**: remove base64\_select_table and base64\_table (Tobias Nießen) [#44425](https://github.com/nodejs/node/pull/44425) - \[[`a3dc7e18ed`](https://github.com/nodejs/node/commit/a3dc7e18ed)] - **src**: fix uv_err_name memory leak (theanarkh) [#44421](https://github.com/nodejs/node/pull/44421) - \[[`a711080061`](https://github.com/nodejs/node/commit/a711080061)] - **src**: make Endianness an enum class (Tobias Nießen) [#44411](https://github.com/nodejs/node/pull/44411) - \[[`aa80826651`](https://github.com/nodejs/node/commit/aa80826651)] - **src**: fix ssize_t error from nghttp2.h (Darshan Sen) [#44393](https://github.com/nodejs/node/pull/44393) - \[[`6b8ed279fd`](https://github.com/nodejs/node/commit/6b8ed279fd)] - **src**: trace fs async api (theanarkh) [#44057](https://github.com/nodejs/node/pull/44057) - \[[`dd08d6cc57`](https://github.com/nodejs/node/commit/dd08d6cc57)] - **src**: simplify and optimize GetOpenSSLVersion() (Tobias Nießen) [#44395](https://github.com/nodejs/node/pull/44395) - \[[`4c27d77e5c`](https://github.com/nodejs/node/commit/4c27d77e5c)] - **src**: simplify ECDH::GetCurves() (Tobias Nießen) [#44309](https://github.com/nodejs/node/pull/44309) - \[[`a6ce1de833`](https://github.com/nodejs/node/commit/a6ce1de833)] - **src**: remove KeyObjectData::symmetric_key_len\_ (Tobias Nießen) [#44346](https://github.com/nodejs/node/pull/44346) - \[[`f0d841fd7d`](https://github.com/nodejs/node/commit/f0d841fd7d)] - **src**: fix multiple format string bugs (Tobias Nießen) [#44314](https://github.com/nodejs/node/pull/44314) - \[[`2f3502f345`](https://github.com/nodejs/node/commit/2f3502f345)] - **src**: make minor improvements to SecureBuffer (Tobias Nießen) [#44302](https://github.com/nodejs/node/pull/44302) - \[[`525fbfd122`](https://github.com/nodejs/node/commit/525fbfd122)] - **src**: use imported namespaces in `node_contextify.cc` (Juan José) [#44299](https://github.com/nodejs/node/pull/44299) - \[[`ac2edbcd8c`](https://github.com/nodejs/node/commit/ac2edbcd8c)] - **src**: refactor to avoid using a moved object (Tobias Nießen) [#44269](https://github.com/nodejs/node/pull/44269) - \[[`b186684b22`](https://github.com/nodejs/node/commit/b186684b22)] - **src**: extract common context embedder tag checks (Chengzhong Wu) [#44258](https://github.com/nodejs/node/pull/44258) - \[[`8195c8108c`](https://github.com/nodejs/node/commit/8195c8108c)] - **src**: avoid copying BaseObjectPtrs in loop (Tobias Nießen) [#44270](https://github.com/nodejs/node/pull/44270) - \[[`c045faf1ea`](https://github.com/nodejs/node/commit/c045faf1ea)] - **src**: fix --heapsnapshot-near-heap-limit error hint (Chengzhong Wu) [#44216](https://github.com/nodejs/node/pull/44216) - \[[`4ee8ac3b6b`](https://github.com/nodejs/node/commit/4ee8ac3b6b)] - **src**: prevent copying ArrayBufferViewContents (Keyhan Vakil) [#44091](https://github.com/nodejs/node/pull/44091) - \[[`8f5fd2f06c`](https://github.com/nodejs/node/commit/8f5fd2f06c)] - **src**: fix to use replacement character (Kohei Ueno) [#43999](https://github.com/nodejs/node/pull/43999) - \[[`78c846265f`](https://github.com/nodejs/node/commit/78c846265f)] - **src**: fix typo in src/README.md (Anna Henningsen) [#44009](https://github.com/nodejs/node/pull/44009) - \[[`ec1645b1f0`](https://github.com/nodejs/node/commit/ec1645b1f0)] - **src**: fix regression that a source marker is lost (cola119) [#43086](https://github.com/nodejs/node/pull/43086) - \[[`0c01922ff7`](https://github.com/nodejs/node/commit/0c01922ff7)] - **src**: remove dead code in base64\_encode (Tobias Nießen) [#43979](https://github.com/nodejs/node/pull/43979) - \[[`28911e21b6`](https://github.com/nodejs/node/commit/28911e21b6)] - **src,buffer**: remove unused chars_written parameter (Keyhan Vakil) [#44092](https://github.com/nodejs/node/pull/44092) - \[[`37010cb862`](https://github.com/nodejs/node/commit/37010cb862)] - **src,fs**: refactor duplicated code in fs.readdir (Daeyeon Jeong) [#43204](https://github.com/nodejs/node/pull/43204) - \[[`1635503704`](https://github.com/nodejs/node/commit/1635503704)] - **src,test**: fix typos (SADIK KUZU) [#44110](https://github.com/nodejs/node/pull/44110) - \[[`ffb1c85784`](https://github.com/nodejs/node/commit/ffb1c85784)] - **stream**: refactor use es2020 statement (SindreXie) [#44533](https://github.com/nodejs/node/pull/44533) - \[[`6ed3367155`](https://github.com/nodejs/node/commit/6ed3367155)] - **(SEMVER-MINOR)** **stream**: add `ReadableByteStream.tee()` (Daeyeon Jeong) [#44505](https://github.com/nodejs/node/pull/44505) - \[[`14c7f4a290`](https://github.com/nodejs/node/commit/14c7f4a290)] - **test**: update WPT runner (Filip Skokan) [#43455](https://github.com/nodejs/node/pull/43455) - \[[`4368acd01a`](https://github.com/nodejs/node/commit/4368acd01a)] - **test**: don't clobber RegExp.$\_ on startup (Ben Noordhuis) [#44864](https://github.com/nodejs/node/pull/44864) - \[[`5854abc176`](https://github.com/nodejs/node/commit/5854abc176)] - **test**: use async/await in test-debugger-auto-resume (samyuktaprabhu) [#44675](https://github.com/nodejs/node/pull/44675) - \[[`a7666abe31`](https://github.com/nodejs/node/commit/a7666abe31)] - **test**: migrated from Promise chains to Async/Await (Rathi N Das) [#44674](https://github.com/nodejs/node/pull/44674) - \[[`5bed2d1f46`](https://github.com/nodejs/node/commit/5bed2d1f46)] - **test**: change promises to async/await in test-debugger-backtrace.js (Juliet Zhang) [#44677](https://github.com/nodejs/node/pull/44677) - \[[`f630881f9b`](https://github.com/nodejs/node/commit/f630881f9b)] - **test**: use async/await in test-debugger-sb-before-load (Hope Olaidé) [#44697](https://github.com/nodejs/node/pull/44697) - \[[`fada3a2ce7`](https://github.com/nodejs/node/commit/fada3a2ce7)] - **test**: add extra tests for basename with ext option (Connor Burton) [#44772](https://github.com/nodejs/node/pull/44772) - \[[`9386c8581c`](https://github.com/nodejs/node/commit/9386c8581c)] - **test**: refactor to async/await (Divya Mohan) [#44694](https://github.com/nodejs/node/pull/44694) - \[[`af2aa5be45`](https://github.com/nodejs/node/commit/af2aa5be45)] - **test**: modify test-debugger-custom-port.js to use async-await (Priya Shastri) [#44680](https://github.com/nodejs/node/pull/44680) - \[[`e9e130925c`](https://github.com/nodejs/node/commit/e9e130925c)] - **test**: update test-debugger-breakpoint-exists.js to use async/await (Archana Kamath) [#44682](https://github.com/nodejs/node/pull/44682) - \[[`510365a036`](https://github.com/nodejs/node/commit/510365a036)] - **test**: use async/await in test-debugger-preserve-breaks (poorvitusam) [#44696](https://github.com/nodejs/node/pull/44696) - \[[`2baa3c3ce5`](https://github.com/nodejs/node/commit/2baa3c3ce5)] - **test**: use async/await in test-debugger-profile (surbhirjain) [#44684](https://github.com/nodejs/node/pull/44684) - \[[`ffc4fadf5e`](https://github.com/nodejs/node/commit/ffc4fadf5e)] - **test**: change the promises to async/await in test-debugger-exec-scope.js (Ankita Khiratkar) [#44685](https://github.com/nodejs/node/pull/44685) - \[[`8b8d18ab4e`](https://github.com/nodejs/node/commit/8b8d18ab4e)] - **test**: verify napi_remove_wrap with napi_delete_reference (Chengzhong Wu) [#44754](https://github.com/nodejs/node/pull/44754) - \[[`863361928e`](https://github.com/nodejs/node/commit/863361928e)] - **test**: change promises to async/await (Madhulika Sharma) [#44683](https://github.com/nodejs/node/pull/44683) - \[[`2e3aa39c94`](https://github.com/nodejs/node/commit/2e3aa39c94)] - **test**: use async/await in test-debugger-invalid-args (Nupur Chauhan) [#44678](https://github.com/nodejs/node/pull/44678) - \[[`095cb7eba1`](https://github.com/nodejs/node/commit/095cb7eba1)] - **test**: update test-debugger-low-level to use await/async (Meghana Ramesh) [#44688](https://github.com/nodejs/node/pull/44688) - \[[`2752d7c22a`](https://github.com/nodejs/node/commit/2752d7c22a)] - **test**: check that sysconf returns a positive value (Tobias Nießen) [#44666](https://github.com/nodejs/node/pull/44666) - \[[`fc1edaf0d7`](https://github.com/nodejs/node/commit/fc1edaf0d7)] - **test**: change promise to async/await in debugger-watcher (“Pooja) [#44687](https://github.com/nodejs/node/pull/44687) - \[[`aae8ff6ace`](https://github.com/nodejs/node/commit/aae8ff6ace)] - **test**: fix test-performance-measure (smitley) [#44637](https://github.com/nodejs/node/pull/44637) - \[[`f13e06ab85`](https://github.com/nodejs/node/commit/f13e06ab85)] - **test**: improve lib/readline.js coverage (MURAKAMI Masahiko) [#42686](https://github.com/nodejs/node/pull/42686) - \[[`a46dd370d7`](https://github.com/nodejs/node/commit/a46dd370d7)] - **test**: fix `test-repl` not validating leaked globals properly (Antoine du Hamel) [#44640](https://github.com/nodejs/node/pull/44640) - \[[`31f809acca`](https://github.com/nodejs/node/commit/31f809acca)] - **test**: ignore stale process cleanup failures on Windows (Joyee Cheung) [#44480](https://github.com/nodejs/node/pull/44480) - \[[`370b0ec5a1`](https://github.com/nodejs/node/commit/370b0ec5a1)] - **test**: use python3 instead of python (Luigi Pinca) [#44545](https://github.com/nodejs/node/pull/44545) - \[[`88dfd50079`](https://github.com/nodejs/node/commit/88dfd50079)] - **test**: fix DebugSymbolsTest.ReqWrapList on PPC64LE (Daniel Bevenius) [#44341](https://github.com/nodejs/node/pull/44341) - \[[`371804752a`](https://github.com/nodejs/node/commit/371804752a)] - **test**: add more cases for parse-encoding (Tony Gorez) [#44427](https://github.com/nodejs/node/pull/44427) - \[[`0c76e01876`](https://github.com/nodejs/node/commit/0c76e01876)] - **test**: split report OOM tests (Joyee Cheung) [#44389](https://github.com/nodejs/node/pull/44389) - \[[`5af3a5d37e`](https://github.com/nodejs/node/commit/5af3a5d37e)] - **test**: avoid race in file write stream handle tests (Joyee Cheung) [#44380](https://github.com/nodejs/node/pull/44380) - \[[`edb3335ff2`](https://github.com/nodejs/node/commit/edb3335ff2)] - **test**: deflake child process exec timeout tests (Joyee Cheung) [#44390](https://github.com/nodejs/node/pull/44390) - \[[`c3429ab2e3`](https://github.com/nodejs/node/commit/c3429ab2e3)] - **test**: make the vm timeout escape tests more lenient (Joyee Cheung) [#44433](https://github.com/nodejs/node/pull/44433) - \[[`b5901a0c26`](https://github.com/nodejs/node/commit/b5901a0c26)] - **test**: split heap prof tests (Joyee Cheung) [#44388](https://github.com/nodejs/node/pull/44388) - \[[`a139f5d4e0`](https://github.com/nodejs/node/commit/a139f5d4e0)] - **test**: fix multiple incorrect mustNotCall() uses (Tobias Nießen) [#44022](https://github.com/nodejs/node/pull/44022) - \[[`6990833a4c`](https://github.com/nodejs/node/commit/6990833a4c)] - **test**: raise sleep times in child process tests (Joyee Cheung) [#44375](https://github.com/nodejs/node/pull/44375) - \[[`b2b9de98a2`](https://github.com/nodejs/node/commit/b2b9de98a2)] - **test**: remove duplicate test (Luigi Pinca) [#44313](https://github.com/nodejs/node/pull/44313) - \[[`c397bb93ad`](https://github.com/nodejs/node/commit/c397bb93ad)] - **test**: make tmpdir.js importable from esm (Geoffrey Booth) [#44322](https://github.com/nodejs/node/pull/44322) - \[[`03b8cb8c4c`](https://github.com/nodejs/node/commit/03b8cb8c4c)] - **test**: deflake test-diagnostics-channel-net (Keyhan Vakil) [#44144](https://github.com/nodejs/node/pull/44144) - \[[`73cd9dd860`](https://github.com/nodejs/node/commit/73cd9dd860)] - **test**: add coverage for invalid RSA-PSS digests (Tobias Nießen) [#44271](https://github.com/nodejs/node/pull/44271) - \[[`003ab59fcc`](https://github.com/nodejs/node/commit/003ab59fcc)] - **test**: move "errors" test to "parallel" (Michaël Zasso) [#44233](https://github.com/nodejs/node/pull/44233) - \[[`4485adeaeb`](https://github.com/nodejs/node/commit/4485adeaeb)] - **test**: mark connection leak test flaky on IBM i (Richard Lau) [#44215](https://github.com/nodejs/node/pull/44215) - \[[`8725a87fd9`](https://github.com/nodejs/node/commit/8725a87fd9)] - **test**: use `mustSucceed` instead of `mustCall` with `assert.ifError` (MURAKAMI Masahiko) [#44196](https://github.com/nodejs/node/pull/44196) - \[[`41ea42bd82`](https://github.com/nodejs/node/commit/41ea42bd82)] - **test**: update hr-time web platform tests (Yagiz Nizipli) [#44100](https://github.com/nodejs/node/pull/44100) - \[[`dd4db8e724`](https://github.com/nodejs/node/commit/dd4db8e724)] - **test**: update console web platform tests (Yagiz Nizipli) [#44100](https://github.com/nodejs/node/pull/44100) - \[[`940e31784e`](https://github.com/nodejs/node/commit/940e31784e)] - **test**: move tests with many workers to sequential (Keyhan Vakil) [#44139](https://github.com/nodejs/node/pull/44139) - \[[`03c0819dd9`](https://github.com/nodejs/node/commit/03c0819dd9)] - **test**: deflake gc-http-client tests by restricting number of requests (Nick Sia) [#44146](https://github.com/nodejs/node/pull/44146) - \[[`3d0a3fe246`](https://github.com/nodejs/node/commit/3d0a3fe246)] - **test**: move test-vm-break-on-sigint to sequential (Keyhan Vakil) [#44140](https://github.com/nodejs/node/pull/44140) - \[[`4cfa9bac90`](https://github.com/nodejs/node/commit/4cfa9bac90)] - **test**: remove test-http-client-response-timeout flaky designation (Luigi Pinca) [#44145](https://github.com/nodejs/node/pull/44145) - \[[`2f036c857e`](https://github.com/nodejs/node/commit/2f036c857e)] - **test**: s390x z15 accelerated zlib fixes (Adam Majer) [#44117](https://github.com/nodejs/node/pull/44117) - \[[`5ed4f431cf`](https://github.com/nodejs/node/commit/5ed4f431cf)] - **test**: tune down parallelism for some flaky tests (Keyhan Vakil) [#44090](https://github.com/nodejs/node/pull/44090) - \[[`ec7b932945`](https://github.com/nodejs/node/commit/ec7b932945)] - **test**: fix `internet/test-inspector-help-page` (Daeyeon Jeong) [#44025](https://github.com/nodejs/node/pull/44025) - \[[`dff6615bbe`](https://github.com/nodejs/node/commit/dff6615bbe)] - **test**: remove test-gc-http-client-timeout from flaky list (Feng Yu) [#43971](https://github.com/nodejs/node/pull/43971) - \[[`6c3228361b`](https://github.com/nodejs/node/commit/6c3228361b)] - **test**: reduce loop times for preventing test from timeout (theanarkh) [#43981](https://github.com/nodejs/node/pull/43981) - \[[`a33daadc41`](https://github.com/nodejs/node/commit/a33daadc41)] - **test**: fix test-cluster-concurrent-disconnect (Daeyeon Jeong) [#43961](https://github.com/nodejs/node/pull/43961) - \[[`e009a35d6e`](https://github.com/nodejs/node/commit/e009a35d6e)] - **test**: change misleading variable name (Tobias Nießen) [#43990](https://github.com/nodejs/node/pull/43990) - \[[`72fb0133f5`](https://github.com/nodejs/node/commit/72fb0133f5)] - **test**: use `common.mustNotMutateObjectDeep()` in fs tests (LiviaMedeiros) [#43819](https://github.com/nodejs/node/pull/43819) - \[[`4ebb3ef508`](https://github.com/nodejs/node/commit/4ebb3ef508)] - **test,crypto**: update WebCryptoAPI WPT (Filip Skokan) [#44223](https://github.com/nodejs/node/pull/44223) - \[[`9a469bef2c`](https://github.com/nodejs/node/commit/9a469bef2c)] - **test_runner**: include stack of uncaught exceptions (Moshe Atlow) [#44614](https://github.com/nodejs/node/pull/44614) - \[[`56dc4b3848`](https://github.com/nodejs/node/commit/56dc4b3848)] - **test_runner**: fix test runner hooks failure stack (Moshe Atlow) [#44284](https://github.com/nodejs/node/pull/44284) - \[[`cefb0586d8`](https://github.com/nodejs/node/commit/cefb0586d8)] - **test_runner**: refactor to use more primordials (Antoine du Hamel) [#44062](https://github.com/nodejs/node/pull/44062) - \[[`64b07a9d14`](https://github.com/nodejs/node/commit/64b07a9d14)] - **test_runner**: verbous error when entire test tree is canceled (Moshe Atlow) [#44060](https://github.com/nodejs/node/pull/44060) - \[[`bfdee2597a`](https://github.com/nodejs/node/commit/bfdee2597a)] - **test_runner**: empty pending tests queue post running (Moshe Atlow) [#44059](https://github.com/nodejs/node/pull/44059) - \[[`0fbedac6ce`](https://github.com/nodejs/node/commit/0fbedac6ce)] - **(SEMVER-MINOR)** **test_runner**: add before/after/each hooks (Moshe Atlow) [#43730](https://github.com/nodejs/node/pull/43730) - \[[`6ad7a86af6`](https://github.com/nodejs/node/commit/6ad7a86af6)] - **test_runner**: fix top level `describe` queuing (Moshe Atlow) [#43998](https://github.com/nodejs/node/pull/43998) - \[[`a2881b7a85`](https://github.com/nodejs/node/commit/a2881b7a85)] - **test_runner**: graceful termination on `--test` only (Moshe Atlow) [#43977](https://github.com/nodejs/node/pull/43977) - \[[`72a8faa087`](https://github.com/nodejs/node/commit/72a8faa087)] - **test_runner**: validate `concurrency` option (Antoine du Hamel) [#43976](https://github.com/nodejs/node/pull/43976) - \[[`8118fc2980`](https://github.com/nodejs/node/commit/8118fc2980)] - **tls**: fix out-of-bounds read in ClientHelloParser (Tobias Nießen) [#44580](https://github.com/nodejs/node/pull/44580) - \[[`b53ea08d7b`](https://github.com/nodejs/node/commit/b53ea08d7b)] - **tls**: remove SecureContext setFreeListLength (Tobias Nießen) [#44300](https://github.com/nodejs/node/pull/44300) - \[[`c35a0713b0`](https://github.com/nodejs/node/commit/c35a0713b0)] - **tls**: use OpenSSL constant for client random size (Tobias Nießen) [#44305](https://github.com/nodejs/node/pull/44305) - \[[`e4b4b370a1`](https://github.com/nodejs/node/commit/e4b4b370a1)] - **tls**: use logical OR operator (Mohammed Keyvanzadeh) [#44236](https://github.com/nodejs/node/pull/44236) - \[[`18e1766346`](https://github.com/nodejs/node/commit/18e1766346)] - **tools**: increase timeout of running WPT (Joyee Cheung) [#44574](https://github.com/nodejs/node/pull/44574) - \[[`006d7f1f2a`](https://github.com/nodejs/node/commit/006d7f1f2a)] - **tools**: refactor deprecated format in no-unescaped-regexp-dot (Madhuri) [#44763](https://github.com/nodejs/node/pull/44763) - \[[`c6289d632a`](https://github.com/nodejs/node/commit/c6289d632a)] - **tools**: update eslint-check.js to object style (andiemontoyeah) [#44706](https://github.com/nodejs/node/pull/44706) - \[[`b06a78e85d`](https://github.com/nodejs/node/commit/b06a78e85d)] - **tools**: update eslint to 8.24.0 (Node.js GitHub Bot) [#44778](https://github.com/nodejs/node/pull/44778) - \[[`ce3397223b`](https://github.com/nodejs/node/commit/ce3397223b)] - **tools**: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) [#44776](https://github.com/nodejs/node/pull/44776) - \[[`1079c8099d`](https://github.com/nodejs/node/commit/1079c8099d)] - **tools**: add update-llhttp.sh (Paolo Insogna) [#44652](https://github.com/nodejs/node/pull/44652) - \[[`0b3f49c749`](https://github.com/nodejs/node/commit/0b3f49c749)] - **tools**: fix typo in update-nghttp2.sh (Luigi Pinca) [#44664](https://github.com/nodejs/node/pull/44664) - \[[`d190e716ad`](https://github.com/nodejs/node/commit/d190e716ad)] - **tools**: add timezone update workflow (Lenvin Gonsalves) [#43988](https://github.com/nodejs/node/pull/43988) - \[[`b6c232f288`](https://github.com/nodejs/node/commit/b6c232f288)] - **tools**: update eslint to 8.23.1 (Node.js GitHub Bot) [#44639](https://github.com/nodejs/node/pull/44639) - \[[`2c0d9ffb65`](https://github.com/nodejs/node/commit/2c0d9ffb65)] - **tools**: update lint-md-dependencies to [@rollup/plugin-node-resolve](https://github.com/rollup/plugin-node-resolve)[@14](https://github.com/14).1.0 (Node.js GitHub Bot) [#44638](https://github.com/nodejs/node/pull/44638) - \[[`f05ce2bff5`](https://github.com/nodejs/node/commit/f05ce2bff5)] - **tools**: update lint-md-dependencies to [@rollup/plugin-node-resolve](https://github.com/rollup/plugin-node-resolve)[@14](https://github.com/14).0.1 (Node.js GitHub Bot) [#44590](https://github.com/nodejs/node/pull/44590) - \[[`657fa792f4`](https://github.com/nodejs/node/commit/657fa792f4)] - **tools**: increase timeout of running WPT (Joyee Cheung) [#44574](https://github.com/nodejs/node/pull/44574) - \[[`602ecaa42f`](https://github.com/nodejs/node/commit/602ecaa42f)] - **tools**: fix shebang to use python3 by default (Himself65) [#44531](https://github.com/nodejs/node/pull/44531) - …

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error. PR-URL: nodejs/node#44410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

tniessen added tls Issues and PRs related to the tls subsystem. crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Aug 26, 2022

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 26, 2022

bnoordhuis approved these changes Aug 27, 2022

View reviewed changes

src/crypto/crypto_common.cc Outdated Show resolved Hide resolved

jasnell approved these changes Aug 28, 2022

View reviewed changes

tniessen force-pushed the src-error-handling-clonesslcerts branch from 60c38fd to 97bc95e Compare August 30, 2022 13:00

src: improve error handling in CloneSSLCerts

936ccbe

If sk_X509_new() returns NULL or if sk_X509_push() fails, return instead of silently ignoring the error.

tniessen force-pushed the src-error-handling-clonesslcerts branch from 97bc95e to 936ccbe Compare August 30, 2022 13:07

tniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 30, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2022

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Aug 31, 2022

CI Reliability 2022-08-31 nodejs/reliability#363

Open

30 tasks

github-actions bot mentioned this pull request Sep 1, 2022

CI Reliability 2022-09-01 nodejs/reliability#364

Open

28 tasks

panva approved these changes Sep 1, 2022

View reviewed changes

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2022

nodejs-github-bot merged commit 82cfb50 into nodejs:main Sep 1, 2022

This was referenced Sep 2, 2022

CI Reliability 2022-09-02 nodejs/reliability#365

Open

CI Reliability 2022-09-03 nodejs/reliability#366

Open

CI Reliability 2022-09-04 nodejs/reliability#367

Open

CI Reliability 2022-09-05 nodejs/reliability#368

Open

RafaelGSS mentioned this pull request Sep 5, 2022

v18.9.0 release proposal #44521

Merged

juanarbol mentioned this pull request Oct 11, 2022

V16.18.0 proposal #44886

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: improve error handling in CloneSSLCerts #44410

src: improve error handling in CloneSSLCerts #44410

tniessen commented Aug 26, 2022

nodejs-github-bot commented Aug 26, 2022

This comment was marked as outdated.

nodejs-github-bot commented Aug 31, 2022

tniessen commented Aug 31, 2022

nodejs-github-bot commented Sep 1, 2022

src: improve error handling in CloneSSLCerts #44410

src: improve error handling in CloneSSLCerts #44410

Conversation

tniessen commented Aug 26, 2022

nodejs-github-bot commented Aug 26, 2022

This comment was marked as outdated.

nodejs-github-bot commented Aug 31, 2022

tniessen commented Aug 31, 2022

nodejs-github-bot commented Sep 1, 2022